sjreganSam
Forum Replies Created
-
Posts
-
Thanks Jason, that would be great.
I’ve also see that
<?php do_action( 'bp_directory_members_item' ); ?>is called twice withingrimlock-buddypress/templates/members/members-loop.php, once on line #34 and again on line #58.It looks like the call on #34 is meant to be for a different action.
Cheers.
Correct, it is not default in BuddyPress or your framework, it is a custom plugin being written by our company for a client.
Thank you for sharing the CSS code, unfortunately this is not an issue that can be resolved through styles.
I have created a feature request.
Thanks.
You can see in the code in the Grimlock BuddyPress plugin the
do_action()call is outside the<card>element.<li class="bp-card-list__item bp-card-list--members__item has-post-thumbnail element-animated fade-in short element-animated-delay element-animated-both"> <div class="card"> <div class="card-img"> <a href="<?php bp_group_member_domain(); ?>"> <?php bp_group_member_avatar_thumb( 'type=full' ); ?> </a> </div> <!-- .card-img --> <div class="card-body pt-1 pb-4 pl-2 pr-2"> <header class="card-body-header entry-header clearfix"> <h2 class="entry-title"> <?php bp_group_member_link(); ?> </h2> <!-- .entry-title --> </header> <!-- .card-body-header --> <div class="card-body-meta"> <div class="bp-member-xprofile-custom-fields"><?php do_action( 'grimlock_buddypress_member_xprofile_custom_fields' ); ?></div> <!-- .bp-member-xprofile-custom-fields --> <div class="card-body-activity"> <?php $group_member_joined_since_args = array( 'relative' => false, ); ?> <span class="activity" data-livestamp="<?php bp_core_iso8601_date( bp_get_group_member_joined_since( $group_member_joined_since_args ) ); ?>"><?php bp_group_member_joined_since(); ?></span> </div><!-- .card-body-activity --> </div> <!-- .card-body-meta --> <?php if ( bp_is_active( 'friends' ) ) : ?> <div class="card-body-actions action"> <?php bp_add_friend_button( bp_get_group_member_id(), bp_get_group_member_is_friend() ); ?> <?php do_action( 'bp_group_members_list_item_action' ); ?> </div> <!-- .card-body-actions --> <?php endif; ?> </div> <!-- .card-body --> </div> <!-- .card --> <?php do_action( 'bp_group_members_list_item' ); ?> </li> <!-- .bp-card-list__item -->
This reply has been marked as private.
Hi Manathan,
Please see the attached screenshots, you can see the members directory has the ‘Not Checked In’ message within the member ‘card’.
However, when you view the members of a single group, the ‘Not Checked In’ appears outside the members ‘card’. This is because the do_action( ‘bp_group_members_list_item’ ) call in Grimlock is not inside the card, and there is no other available action to add additional content inside the card within Grimlock.
Thanks.
Brilliant, thank you.
Hi,
A similar issue but this time in the Grimlock Login v1.1.10 plugin. Would you like me to open a new topic?
[08-Mar-2022 04:21:17 UTC] PHP Notice: Undefined index: font-weight in /sites/example/wp-content/plugins/grimlock-login/inc/class-grimlock-login.php on line 181 [08-Mar-2022 04:21:17 UTC] PHP Stack trace: [08-Mar-2022 04:21:17 UTC] PHP 1. {main}() /sites/example/wp-login.php:0 [08-Mar-2022 04:21:17 UTC] PHP 2. login_header() /sites/example/wp-login.php:1371 [08-Mar-2022 04:21:17 UTC] PHP 3. do_action() /sites/example/wp-login.php:114 [08-Mar-2022 04:21:17 UTC] PHP 4. WP_Hook->do_action() /sites/example/wp-includes/plugin.php:474 [08-Mar-2022 04:21:17 UTC] PHP 5. WP_Hook->apply_filters() /sites/example/wp-includes/class-wp-hook.php:331 [08-Mar-2022 04:21:17 UTC] PHP 6. Grimlock_Login->login_enqueue_styles() /sites/example/wp-includes/class-wp-hook.php:307 [08-Mar-2022 04:21:17 UTC] PHP 7. Grimlock_Login->get_google_fonts_url() /sites/example/wp-content/plugins/grimlock-login/inc/class-grimlock-login.php:75 [08-Mar-2022 04:21:17 UTC] PHP Notice: Undefined index: font-size in /sites/example/wp-content/plugins/grimlock-login/inc/customizer/class-grimlock-login-typography-customizer.php on line 49 [08-Mar-2022 04:21:17 UTC] PHP Stack trace: [08-Mar-2022 04:21:17 UTC] PHP 1. {main}() /sites/example/wp-login.php:0 [08-Mar-2022 04:21:17 UTC] PHP 2. login_header() /sites/example/wp-login.php:1371 [08-Mar-2022 04:21:17 UTC] PHP 3. do_action() /sites/example/wp-login.php:114 [08-Mar-2022 04:21:17 UTC] PHP 4. WP_Hook->do_action() /sites/example/wp-includes/plugin.php:474 [08-Mar-2022 04:21:17 UTC] PHP 5. WP_Hook->apply_filters() /sites/example/wp-includes/class-wp-hook.php:331 [08-Mar-2022 04:21:17 UTC] PHP 6. Grimlock_Login_Typography_Customizer->enqueue_styles() /sites/example/wp-includes/class-wp-hook.php:307 [08-Mar-2022 04:21:17 UTC] PHP Notice: Undefined index: letter-spacing in /sites/example/wp-content/plugins/grimlock-login/inc/customizer/class-grimlock-login-typography-customizer.php on line 51 [08-Mar-2022 04:21:17 UTC] PHP Stack trace: [08-Mar-2022 04:21:17 UTC] PHP 1. {main}() /sites/example/wp-login.php:0 [08-Mar-2022 04:21:17 UTC] PHP 2. login_header() /sites/example/wp-login.php:1371 [08-Mar-2022 04:21:17 UTC] PHP 3. do_action() /sites/example/wp-login.php:114 [08-Mar-2022 04:21:17 UTC] PHP 4. WP_Hook->do_action() /sites/example/wp-includes/plugin.php:474 [08-Mar-2022 04:21:17 UTC] PHP 5. WP_Hook->apply_filters() /sites/example/wp-includes/class-wp-hook.php:331 [08-Mar-2022 04:21:17 UTC] PHP 6. Grimlock_Login_Typography_Customizer->enqueue_styles() /sites/example/wp-includes/class-wp-hook.php:307 [08-Mar-2022 04:21:17 UTC] PHP Notice: Undefined index: line-height in /sites/example/wp-content/plugins/grimlock-login/inc/customizer/class-grimlock-login-typography-customizer.php on line 52 [08-Mar-2022 04:21:17 UTC] PHP Stack trace: [08-Mar-2022 04:21:17 UTC] PHP 1. {main}() /sites/example/wp-login.php:0 [08-Mar-2022 04:21:17 UTC] PHP 2. login_header() /sites/example/wp-login.php:1371 [08-Mar-2022 04:21:17 UTC] PHP 3. do_action() /sites/example/wp-login.php:114 [08-Mar-2022 04:21:17 UTC] PHP 4. WP_Hook->do_action() /sites/example/wp-includes/plugin.php:474 [08-Mar-2022 04:21:17 UTC] PHP 5. WP_Hook->apply_filters() /sites/example/wp-includes/class-wp-hook.php:331 [08-Mar-2022 04:21:17 UTC] PHP 6. Grimlock_Login_Typography_Customizer->enqueue_styles() /sites/example/wp-includes/class-wp-hook.php:307 [08-Mar-2022 04:21:17 UTC] PHP Notice: Undefined index: text-transform in /sites/example/wp-content/plugins/grimlock-login/inc/customizer/class-grimlock-login-typography-customizer.php on line 53 [08-Mar-2022 04:21:17 UTC] PHP Stack trace: [08-Mar-2022 04:21:17 UTC] PHP 1. {main}() /sites/example/wp-login.php:0 [08-Mar-2022 04:21:17 UTC] PHP 2. login_header() /sites/example/wp-login.php:1371 [08-Mar-2022 04:21:17 UTC] PHP 3. do_action() /sites/example/wp-login.php:114 [08-Mar-2022 04:21:17 UTC] PHP 4. WP_Hook->do_action() /sites/example/wp-includes/plugin.php:474 [08-Mar-2022 04:21:17 UTC] PHP 5. WP_Hook->apply_filters() /sites/example/wp-includes/class-wp-hook.php:331 [08-Mar-2022 04:21:17 UTC] PHP 6. Grimlock_Login_Typography_Customizer->enqueue_styles() /sites/example/wp-includes/class-wp-hook.php:307 [08-Mar-2022 04:21:17 UTC] PHP Notice: Undefined index: font-size in /sites/example/wp-content/plugins/grimlock-login/inc/customizer/class-grimlock-login-typography-customizer.php on line 63 [08-Mar-2022 04:21:17 UTC] PHP Stack trace: [08-Mar-2022 04:21:17 UTC] PHP 1. {main}() /sites/example/wp-login.php:0 [08-Mar-2022 04:21:17 UTC] PHP 2. login_header() /sites/example/wp-login.php:1371 [08-Mar-2022 04:21:17 UTC] PHP 3. do_action() /sites/example/wp-login.php:114 [08-Mar-2022 04:21:17 UTC] PHP 4. WP_Hook->do_action() /sites/example/wp-includes/plugin.php:474 [08-Mar-2022 04:21:17 UTC] PHP 5. WP_Hook->apply_filters() /sites/example/wp-includes/class-wp-hook.php:331 [08-Mar-2022 04:21:17 UTC] PHP 6. Grimlock_Login_Typography_Customizer->enqueue_styles() /sites/example/wp-includes/class-wp-hook.php:307Thanks.
This reply has been marked as private.
Thanks for trying, it’s setup in Google Workplace so we don’t have any issues elsewhere.
This reply has been marked as private.
I still did not receive the reply, I am subscribed to the topic.
Regarding the PHP notice, I have traced the issue to this line:
plugins/grimlock/inc/customizer/class-grimlock-navigation-customizer.php:867It should be:
‘output’ => [ $this->get_css_var_output( ‘navigation_sub_menu_border_color’ ) ],Thanks for your response, I understand in this instance it does not break my websites but it does indicate a bug which is why I’m reporting it.
Not sure if this error is related?
[08-Feb-2022 00:06:00 UTC] PHP Notice: Kirki\Module\CSS::field_init was called <strong>incorrectly</strong>. "output" invalid format in field . The "output" argument should be defined as an array of arrays. Please see <a href="https://wordpress.org/support/article/debugging-in-wordpress/">Debugging in WordPress</a> for more information. (This message was added in version 3.0.10.) in /example/wp-includes/functions.php on line 5768 [08-Feb-2022 00:06:00 UTC] PHP Stack trace: [08-Feb-2022 00:06:00 UTC] PHP 1. {main}() /example/index.php:0 [08-Feb-2022 00:06:00 UTC] PHP 2. require() /example/index.php:17 [08-Feb-2022 00:06:00 UTC] PHP 3. require_once() /example/wp-blog-header.php:13 [08-Feb-2022 00:06:00 UTC] PHP 4. require_once() /example/wp-load.php:50 [08-Feb-2022 00:06:00 UTC] PHP 5. require_once() /example/wp-config.php:98 [08-Feb-2022 00:06:00 UTC] PHP 6. do_action() /example/wp-settings.php:609 [08-Feb-2022 00:06:00 UTC] PHP 7. WP_Hook->do_action() /example/wp-includes/plugin.php:474 [08-Feb-2022 00:06:00 UTC] PHP 8. WP_Hook->apply_filters() /example/wp-includes/class-wp-hook.php:331 [08-Feb-2022 00:06:00 UTC] PHP 9. Kirki\Field\Color->Kirki\{closure:/example/wp-content/plugins/kirki/packages/kirki-framework/field/src/Field.php:92-94}() /example/wp-includes/class-wp-hook.php:307 [08-Feb-2022 00:06:00 UTC] PHP 10. do_action() /example/wp-content/plugins/kirki/packages/kirki-framework/field/src/Field.php:93 [08-Feb-2022 00:06:00 UTC] PHP 11. WP_Hook->do_action() /example/wp-includes/plugin.php:474 [08-Feb-2022 00:06:00 UTC] PHP 12. WP_Hook->apply_filters() /example/wp-includes/class-wp-hook.php:331 [08-Feb-2022 00:06:00 UTC] PHP 13. Kirki\Module\CSS->field_init() /example/wp-includes/class-wp-hook.php:307 [08-Feb-2022 00:06:00 UTC] PHP 14. _doing_it_wrong() /example/wp-content/plugins/kirki/packages/kirki-framework/module-css/src/CSS.php:133 [08-Feb-2022 00:06:00 UTC] PHP 15. trigger_error() /example/wp-includes/functions.php:5768
This reply has been marked as private.
I have checked my Spam folder, it is not there.
Is it normal to have no email settings in my profile settings?
Thanks.
The problem is I am constantly watching the debug log as I am developing and these kind of errors make it hard to spot errors in my code versus other plugins 🙂
So for anyone else finding this topic, I use this to stop this error polluting the log file:
add_filter( 'doing_it_wrong_trigger_error', function ( $trigger, $function ) { if ( ! $trigger ) { return $trigger; } $disable = [ 'Kirki_Field::set_output' ]; return ! in_array( $function, $disable ); }, 10, 2 );Also, are you aware your forum has issues notifying of replies? i.e. I no longer receive any emails when someone responds.
@themoceratops Thank you very much for looking into it and the extra details. I will take it from here with my hosting provider.
This reply has been marked as private.
Thanks for looking into it, the issue no longer occurs after manually updating all the plugins.
Icons only could work nicely, there will be a few challenges with it:
1. Touch screens cannot support tooltips.
2. Plugins that add new nav menu items would all have the same icon (so setting icons would need to be fully supported in child themes via CSS).
3. The number of icons may still exceed the available window width on small devices.
4. Careful design consideration will need to be applied to icons that have an item count and those that don’t – this will easily look odd.It would be great if it was configurable, either through WP admin setting or a filter to decide whether to use icons only or same style as primary BP nav.
Thanks for the clarification, I look forward to the future version where my clients can control the colours.
@themosaurusrex yes, that is correct, it would be great if you could do something similar for the secondary BP menu as you are doing for the primary BP menu.
I was just testing out your primary menu navigation and it seems to behave a bit oddly (spacing, z-index, non-responsive). Please see attached screenshots.
Screen-Shot-2020-06-03-at-12.05.08-pm
Screen-Shot-2020-06-03-at-12.06.03-pm
Screen-Shot-2020-06-03-at-12.07.04-pm
Screen-Shot-2020-06-03-at-12.08.25-pm
@themosaurusrex What I would like to see is my background image hiding the background colour after the image has been completely loaded.
What is happening is the background color always hides the background image.
To recreate: add the widget with the default settings and then choose a background image for the widget.
Please see the screenshot attached, you can see in the inline styles the background image has been added to
div.grimlock-region, whereas the background colour has been added todiv.region__inner. If the background color was instead applied todiv.grimlock-regionthere wouldn’t be an issue.
@themosaurusrex Thank you for the detailed reply.
As I spend my time developing plugins and extending your theme I always have my developer tools open, so my underpowered laptop and I will be thankful when this release happens 🙂
For anyone else who finds this thread before the release, I used this to reduce the server load in my nginx hosts file:
location ~ \.map$ {return 200;}
